chore(docs): add explicit documention for parts of devcontainer spec supported by envbuilder #408
+128
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…supported by envbuilder
mafredri
reviewed
Nov 6, 2024
bpmct
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
This is awesome, thanks for putting this together!
Thoughts on also linking to it here? https://containers.dev/supporting
mtojek
approved these changes
Nov 6, 2024
docs/devcontainer-spec-support.md
Outdated
| The last column indicates any currently existing GitHub issue for tracking support for this feature. | ||
| Feel free to [create a new issue](https://github.com/coder/envbuilder/issues/new) if you'd like Envbuilder to support a particular feature. | ||
|
|
||
| | Status | Name | Description | Known Issues | |
There was a problem hiding this comment.
nit: can we sort them in lex. order?
There was a problem hiding this comment.
I intentionally kept the same ordering as https://containers.dev/implementors/json_reference/
There was a problem hiding this comment.
Ok, let's leave it them. I admit this might be hard to find an interesting item without ctrl+f.
docs/devcontainer-spec-support.md
Outdated
|
|
||
| | Status | Name | Description | Known Issues | | ||
| | ----------------------------- | ------------------------------------- | ---------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------ | | ||
| | **General** | | | |
There was a problem hiding this comment.
should we present supported features first?
There was a problem hiding this comment.
I'm going to punt on ordering for now as it's fairly easy to change in a separate PR.
bpmct
reviewed
Nov 6, 2024
bpmct
reviewed
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a nice comprehensive table detailing the parts of the spec we currently do or do not support.